Console View

Categories: default personal

Legend:

Passed

Failed

Warnings

Failed Again

Running

Exception

Offline

No data

default

personal

fd025ba3f5f8...

Jason Ish

ish@unx.ca

rust: require jansson for rust build

build gt4: 'make distcheck' failed - stdio

f715b0ae6b4a...

Jason Ish

ish@unx.ca

doc: add pid-file section to suricata.yaml doc
Redmine issue:
https://redmine.openinfosecfoundation.org/issues/2104

build gt4: 'make distcheck' failed - stdio

e087d938833b...

Victor Julien

victor@inliniac.net

detect: reject dsize rules that can't match
Rules can contain conflicting statements and lead to a unmatchable rule.

2 examples are rejected by this patch:

1. dsize < content
2. dsize < content@offset

Bug #2187

build gt4: 'make distcheck' failed - stdio

df3a3c785734...

Victor Julien

victor@inliniac.net

der/asn1: limit recursion
Limit the number of recursive calls in the DER/ASN.1 decoder to avoid
stack overflows.

Found using AFL.

dbd2d7c05805...

Victor Julien

victor@inliniac.net

detect: more gracefully handle mpm prepare failure
Exit with error instead of using the detection engine in a broken state.

Bug #2187

build gt4: 'make distcheck' failed - stdio

d459d0b352ed...

Victor Julien

victor@inliniac.net

lua/alert: expose transaction if available
Bug #1748.

d32ba60b517b...

Sebastian Garcia

eldraco@gmail.com

Update public-data-sets.rst with stratosphere project
Add the datasets of the Stratosphere project to the list.

build gt4: 'make distcheck' failed - stdio

d1e839eabcc6...

Victor Julien

victor@inliniac.net

windows: use wpcap instead of pcap
Windows pcap libraries such as winpcap all use a library name of
wpcap instead of just pcap. Support this in configure.

build gt4: 'make distcheck' failed - stdio

d1b6be99def9...

Victor Julien

victor@inliniac.net

mingw: fix random function

build gt4: 'make distcheck' failed - stdio

c18e950d7d6a...

Victor Julien

victor@inliniac.net

isdataat: fix mem leak

c02739e535e6...

Victor Julien

victor@inliniac.net

mingw: don't try to build unix socket

build gt4: 'make distcheck' failed - stdio

afed6fe4a224...

Victor Julien

victor@inliniac.net

cleanup: remove all uint use

build gt4: 'make distcheck' failed - stdio

a306ccfd34e7...

Victor Julien

victor@inliniac.net

rust/nfs: implement events
Remove lots of panic statements in favor of setting non-fatal events.

Bug #2175.

96b2e8afc02b...

Victor Julien

victor@inliniac.net

gcc7: fixes for format string warnings
GCC 7.1.1 on Fedora gave several warnings with -Wimplicit-fallthrough
and -Wformat-truncation

This patch addresses the warnings.

95a781d4b208...

Jason Ish

ish@unx.ca

suricata.yaml: better comment on pid-file option
Redmine issue:
https://redmine.openinfosecfoundation.org/issues/2104

build gt4: 'make distcheck' failed - stdio

92f15b7ffbcf...

Jason Ish

ish@unx.ca

doc: move log rotation to output section

build gt4: 'make distcheck' failed - stdio

90e612d3e4c0...

Victor Julien

victor@inliniac.net

cocci: ban memmem

build gt4: 'make distcheck' failed - stdio

8dd077943c58...

Victor Julien

victor@inliniac.net

ssl: minor code reformatting

8c31cd4beae9...

Victor Julien

victor@inliniac.net

win32: minor compile warning fixes

build gt4: 'make distcheck' failed - stdio

83c385a98fd6...

Jason Ish

ish@unx.ca

dnp3: use BasicSearch instead of memmem
Mingw doesn't support memmem.

build gt4: 'make distcheck' failed - stdio

82bd732f4e7f...

Victor Julien

victor@inliniac.net

rust/nfs: improve proto detect

7e72553ff8b5...

Victor Julien

victor@inliniac.net

gcc7: fix format truncation warning
detect-rpc.c: In function ‘DetectRpcParse’:
detect-rpc.c:225:50: error: ‘%s’ directive argument is null [-Werror=format-truncation=]
SCLogError(SC_ERR_INVALID_VALUE, "invalid rpc option %s",args[i]);
^
util-debug.h:239:77: note: in definition of macro ‘SCLogErr’
int _sc_log_ret = snprintf(_sc_log_msg, SC_LOG_MAX_LOG_MSG_LEN, __VA_ARGS__); \
^~~~~~~~~~~
detect-rpc.c:225:17: note: in expansion of macro ‘SCLogError’
SCLogError(SC_ERR_INVALID_VALUE, "invalid rpc option %s",args[i]);
^~~~~~~~~~

74f4f6dd633e...

Victor Julien

victor@inliniac.net

gcc7: format-truncation fix for lua

6b4a04510a37...

Victor Julien

victor@inliniac.net

rust/nfs: remove debug rec_size check
Records larger than 40k are perfectly valid.

Bug #2162.

6a4cefb7c58c...

Jason Ish

ish@unx.ca

rust: --enable-rust-strict to turn warnings into errors

build gt4: 'make distcheck' failed - stdio

62b6f9fe25d5...

Victor Julien

victor@inliniac.net

decode: add config option to disable teredo
Ticket #744.

5ea58fe3c4e2...

Victor Julien

victor@inliniac.net

cocci: add test to check for uint use
uint is non-standard and not supported by MinGW. So ban it's use.

spatch file by Eric Leblond.

build gt4: 'make distcheck' failed - stdio

5b84c01cd356...

Victor Julien

victor@inliniac.net

gcc7: fix format-truncation warnings in runmodes
Example:

util-runmodes.c: In function ‘RunModeSetIPSAutoFp’:
util-runmodes.c:496:40: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=]
snprintf(qname, sizeof(qname), "pickup%d", thread+1);
^~~~~~~~~~
util-runmodes.c:496:9: note: ‘snprintf’ output between 8 and 17 bytes into a destination of size16
snprintf(qname, sizeof(qname), "pickup%d", thread+1);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Solved by reducing 'thread' to a uint16_t and limiting the max
thread count to 1024.

5afe1a981472...

Victor Julien

victor@inliniac.net

stream: don't reset state on syn/ack resend
Bug #1958.

The reset was originally created for issue #523, but that works
well without the reset as well.

59d69666ea4a...

Jason Ish

ish@unx.ca

doc: add more details to log rotation doc

build gt4: 'make distcheck' failed - stdio

5781c8fc780f...

Victor Julien

victor@inliniac.net

pcre: fix \xHH issue for http_host
The http_host keyword checks if the regex contains uppercase characters.
This check was rejecting valid syntax in the following format:

content:"|2E|suricata"; http_host; pcre:"/\x2Esuricata$/W";

This patch addresses this case.

Bug #1957.

57791bd670d0...

Victor Julien

victor@inliniac.net

changelog: update for 4.0.0-rc2 release

52b39a41e0fb...

Victor Julien

victor@inliniac.net

stats: print alert count at shutdown
Bug #1855.

3e9b583d479f...

Victor Julien

victor@inliniac.net

radix: fix risky malloc call
GCC7 said:
CC util-radix-tree.o
In file included from util-debug-filters.h:29:0,
from util-debug.h:34,
from suricata-common.h:421,
from util-radix-tree.c:26:
util-radix-tree.c: In function ‘SCRadixAddKey’:
util-mem.h:177:12: error: argument 1 range [18446744071562067968, 18446744073709551615] exceeds maximum object size 9223372036854775807 [-Werror=alloc-size-larger-than=]
ptrmem = malloc((a)); \
~~~~~~~^~~~~~~~~~~~~
util-radix-tree.c:749:42: note: in expansion of macro ‘SCMalloc’
if ( (inter_node->netmasks = SCMalloc((node->netmask_cnt - i) *
^~~~~~~~
In file included from suricata-common.h:69:0,
from util-radix-tree.c:26:
/usr/include/stdlib.h:443:14: note: in a call to allocation function ‘malloc’ declared here
extern void *malloc (size_t __size) __THROW __attribute_malloc__ __wur;
^~~~~~

scan-build said:
util-radix-tree.c:749:42: warning: Call to 'malloc' has an allocation size of 0 bytes
if ( (inter_node->netmasks = SCMalloc((node->netmask_cnt - i) *
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./util-mem.h:177:14: note: expanded from macro 'SCMalloc'
ptrmem = malloc((a)); \
^~~~~~~~~~~
1 warning generated.

3c05379cbd43...

Victor Julien

victor@inliniac.net

detect: fix mix of pass and noalert
Noalert rules did not apply pass logic to the flow.

Bug #1888.

3063851d8552...

Jason Ish

ish@unx.ca

rust/dns/tcp - probe even if payload is short
As the DNS probe just uses the query portion of a response, don't
require there to be as many bytes as specified in the TCP DNS
header. This can occur in large responses where probe is called
without all the data.

Fixes the cases where the app proto is recorded as failed.

Fixes issue:
https://redmine.openinfosecfoundation.org/issues/2169

16921b6b99ac...

Jason Ish

ish@unx.ca

travis: enable strict rust; use rust 1.15.0
Adds --enable-rust-strict to fail on warnings. Also update
the minimum Rust version from 1.7.0 to 1.15.0.

build gt4: 'make distcheck' failed - stdio

16845d8c9221...

Victor Julien

victor@inliniac.net

pcap-log: fix path construct check

1236578a7cbd...

Victor Julien

victor@inliniac.net

proto detect: improve 'failed' handling
Don't try to call parser for 'failed'. Also don't set one direction
warning if TS is failed and our direction is unknown/complete so failed
as well.

091290dd1c0e...

Eric Leblond

eric@regit.org

app-layer: increment flow counter if one sided
In the case of protocol like SMTP, we detect application layer on
only one side. Consequence was a missed increment in the flow
counter.